Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diag for Eye #270

Merged
merged 2 commits into from
Jul 3, 2023
Merged

diag for Eye #270

merged 2 commits into from
Jul 3, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jun 29, 2023

After this,

julia> E = Eye(4)
4×4 Eye{Float64}

julia> diag(E,1)
3-element Fill{Float64}, with entries equal to 0.0

julia> diag(E)
4-element Fill{Float64}, with entries equal to 1.0

diag returns a Fill

@codecov
Copy link

codecov bot commented Jun 29, 2023 •
edited
Loading

Codecov Report

Merging #270 (19b2292) into master (655c089) will increase coverage by 99.75%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master     #270       +/-   ##
===========================================
+ Coverage    0.00%   99.75%   +99.75%     
===========================================
  Files           5        5               
  Lines         814      819        +5     
===========================================
+ Hits            0      817      +817     
+ Misses        814        2      -812
Impacted Files Coverage Δ
src/FillArrays.jl 99.43% <100.00%> (+99.43%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jishnub jishnub mentioned this pull request Jun 30, 2023
Merged
@jishnub
Copy link
Member Author

jishnub commented Jul 3, 2023

Gentle bump @dlfivefifty

@dlfivefifty dlfivefifty merged commit ac19566 into JuliaArrays:master Jul 3, 2023
22 checks passed
@jishnub jishnub deleted the eyediag branch July 3, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jishnub @dlfivefifty